Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress warning from actionview controller helper. #29918

Conversation

xtina-starr
Copy link
Contributor

Since the commit 3cb7fe5, ActionView :: Helpers::ControllerHelper started showing a warning(see below) because of the * operator. This commit changes the delegate call to use parentheses so it won't show warnings any more.

/Users/artsy/Artsy/oss/rails/actionview/lib/action_view/helpers/controller_helper.rb:14: warning: `*' interpreted as argument prefix

Explicitly pass a destructed array to the delegate method.

Signed-off-by: Yuki Nishijima <yk.nishijima@gmail.com>
@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @pixeltrix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@rafaelfranca rafaelfranca merged commit 8b67e98 into rails:master Jul 24, 2017
@xtina-starr xtina-starr deleted the suppress-warning-from-actionview-controller-helper branch July 24, 2017 20:53
y-yagi pushed a commit to y-yagi/rails that referenced this pull request Aug 15, 2017
…-actionview-controller-helper

Suppress warning from actionview controller helper.
rafaelfranca added a commit that referenced this pull request Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants