Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let ActiveStorage tests pass only for Disk #30030

Merged
merged 1 commit into from
Aug 1, 2017

Commits on Aug 1, 2017

  1. Let ActiveStorage tests pass only for Disk

    If you have a "service/configurations.yml" file, but every single line is
    commented out, then an error occurs when running tests:
    
    ```
    git:active-storage-import~/code/rails/activestorage$ rake
    ~/code/rails/activestorage/test/test_helper.rb:17:in `<top (required)>': undefined method `deep_symbolize_keys' for false:FalseClass (NoMethodError)
    	from ~/code/rails/activestorage/test/controllers/direct_uploads_controller_test.rb:1:in `require'
    ```
    
    The reason is that `YAML.load(..an empty file content..)` simply returns `false`, and not `{}`.
    
    This PR fixes this behavior so tests can also run when no remote service
    is available.
    claudiob committed Aug 1, 2017
    Configuration menu
    Copy the full SHA
    8b20789 View commit details
    Browse the repository at this point in the history