Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add instrumentation for read_multi #30268

merged 1 commit into from Jan 11, 2018


Copy link


add instrumentation for read_multi as currently it's not possible to know what the hit rates are from read_multi

Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

Copy link

@maclover7 maclover7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice! Should we add a entry as well?

Copy link
Contributor Author updated 👍

currently it's not possible to know what the hit rates are from read_multi
Copy link
Contributor Author

Rebased to resolve conflict with master on anything else I could do to help move this forward?

@kamipo kamipo merged commit 6202388 into rails:master Jan 11, 2018
kamipo added a commit that referenced this pull request Jan 11, 2018
@ignatiusreza ignatiusreza deleted the instrumentation branch January 16, 2018 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

5 participants