-
Notifications
You must be signed in to change notification settings - Fork 21.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add instrumentation for read_multi #30268
Conversation
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 nice! Should we add a CHANGELOG.md entry as well?
f94b993
to
6c6447d
Compare
CHANGELOG.md updated 👍 |
6c6447d
to
9c92aa8
Compare
currently it's not possible to know what the hit rates are from read_multi
9c92aa8
to
6202388
Compare
Rebased to resolve conflict with master on CHANGELOG.md.. anything else I could do to help move this forward? |
add instrumentation for read_multi
Summary
add instrumentation for read_multi as currently it's not possible to know what the hit rates are from read_multi