Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add instrumentation for read_multi #30268

Merged
merged 1 commit into from Jan 11, 2018
Merged

Conversation

@ignatiusreza
Copy link
Contributor

@ignatiusreza ignatiusreza commented Aug 15, 2017

Summary

add instrumentation for read_multi as currently it's not possible to know what the hit rates are from read_multi

@rails-bot
Copy link

@rails-bot rails-bot commented Aug 15, 2017

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

Copy link
Member

@maclover7 maclover7 left a comment

👍 nice! Should we add a CHANGELOG.md entry as well?

@ignatiusreza ignatiusreza force-pushed the ignatiusreza:instrumentation branch Aug 18, 2017
@ignatiusreza
Copy link
Contributor Author

@ignatiusreza ignatiusreza commented Aug 18, 2017

CHANGELOG.md updated 👍

@ignatiusreza ignatiusreza force-pushed the ignatiusreza:instrumentation branch Dec 29, 2017
currently it's not possible to know what the hit rates are from read_multi
@ignatiusreza ignatiusreza force-pushed the ignatiusreza:instrumentation branch to 6202388 Dec 29, 2017
@ignatiusreza
Copy link
Contributor Author

@ignatiusreza ignatiusreza commented Dec 29, 2017

Rebased to resolve conflict with master on CHANGELOG.md.. anything else I could do to help move this forward?

@kamipo kamipo merged commit 6202388 into rails:master Jan 11, 2018
2 checks passed
2 checks passed
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
kamipo added a commit that referenced this pull request Jan 11, 2018
add instrumentation for read_multi
@ignatiusreza ignatiusreza deleted the ignatiusreza:instrumentation branch Jan 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants