Fixes ActiveSupport::Cache::FileStore#cleanup bug which prevented it from removing expired entries

[erichmachado]

Summary

ActiveSupport::Cache::FileStore#cleanup implementation was silently failing to remove expired entries from the cache storage directory. This was due to the implementation itself failing to read the entry properly during the cleanup call:

def cleanup(options = nil)
  options = merged_options(options)
  search_dir(cache_path) do |fname|
    key = file_path_key(fname)
    entry = read_entry(key, options)
    delete_entry(key, options) if entry && entry.expired?
  end
end

The read_entry method here should receive the actual fname instead of key to retrieve this entry, otherwise it will just return nil and never calls delete_entry.

This was already reported here.

[rails-bot]

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @georgeclaghorn (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.