New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bulk alter support for PostgreSQL #31331

Merged
merged 1 commit into from Jan 3, 2018

Conversation

Projects
None yet
4 participants
@dinahshi
Contributor

dinahshi commented Dec 5, 2017

30176f2 introduced a bulk: true option to MySQL adapter's change_table,
which aggregates multiple column changes into a single complex ALTER TABLE
statement. This change extends the feature to PostgreSQL.

Considerations

  • MySQL's bulk_change_table lives in
    ConnectionAdapters::AbstractMysqlAdapter, perhaps these methods should be
    moved to ConnectionAdapters::PostgreSQLAdapter?
@rails-bot

This comment has been minimized.

Show comment
Hide comment
@rails-bot

rails-bot Dec 5, 2017

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @schneems (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

rails-bot commented Dec 5, 2017

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @schneems (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@dinahshi

This comment has been minimized.

Show comment
Hide comment
@dinahshi
Contributor

dinahshi commented Dec 29, 2017

@matthewd matthewd merged commit 7098f28 into rails:master Jan 3, 2018

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@matthewd

This comment has been minimized.

Show comment
Hide comment
@matthewd

matthewd Jan 3, 2018

Member

Looks great!

As discussed, I think we can ultimately unify bulk_change_table so it only needs to live in abstract, but this looks good as is, and sets us up perfectly for that step.

Member

matthewd commented Jan 3, 2018

Looks great!

As discussed, I think we can ultimately unify bulk_change_table so it only needs to live in abstract, but this looks good as is, and sets us up perfectly for that step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment