Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
PostgreSQL 10 new relkind for partitioned tables #31336
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @eileencodes (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.
Please see the contribution instructions for more information.
This is a bit of a drive-by comment, because I haven't actually read through to check this is where you need to look, but I think you want https://github.com/rails/rails/tree/master/activerecord/test/cases/adapters/postgresql and https://github.com/rails/rails/blob/master/activerecord/test/cases/view_test.rb.
The former is where all the PG-specific tests go; the latter is, I believe, basically testing the
I don't know of a specific one off the top of my head, but I expect you'll find a number of version gates on tests inside
referenced this pull request
Jun 6, 2018
Hi, I'm interested in this pull request then I am attempting to update a test for this.
Somehow, it looks like this table has not created. It is likely this transaction has not committed.