Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix protected environments with symbols #31423

Merged

Conversation

bogdanvlviv
Copy link
Contributor

  • Convert protected_environments to an array of strings
    It will prevent ignoring environments name of which is a Symbol
    config.active_record.protected_environments = ['staging', :production]
    
  • Update 'Configuring Rails Applications' guide
    • Add mention about config.active_record.internal_metadata_table_name
    • Add mention about config.active_record.protected_environments

@rails-bot
Copy link

r? @georgeclaghorn

(@rails-bot has picked a reviewer for you, use r? to override)

  These changes prevent ignoring environments name of which is a `Symbol`
  ```
  config.active_record.protected_environments = ['staging', :production]
  ```
  - Add mention about `config.active_record.internal_metadata_table_name`
  - Add mention about `config.active_record.protected_environments`
@bogdanvlviv bogdanvlviv force-pushed the fix-protected_environments-with-symbols branch from 269e615 to 011e641 Compare December 12, 2017 23:31
@kamipo kamipo merged commit 2934018 into rails:master Dec 13, 2017
@bogdanvlviv bogdanvlviv deleted the fix-protected_environments-with-symbols branch December 13, 2017 08:28
kamipo added a commit that referenced this pull request Jan 3, 2018
…-with-symbols

Fix protected environments with symbols
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants