New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `touch_all` method to `ActiveRecord::Relation` #31513

Merged
merged 1 commit into from Apr 20, 2018

Conversation

Projects
None yet
4 participants
@fatkodima
Contributor

fatkodima commented Dec 19, 2017

This PR is an update for #8343.

Differences/changes:

  • accepts multiple column names
  • accepts optional time argument
  • addresses optimistic locking
  • not hardcoding :updated_at/on as an always updated column
@rails-bot

This comment has been minimized.

Show comment
Hide comment
@rails-bot

rails-bot Dec 19, 2017

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

rails-bot commented Dec 19, 2017

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@kddeisz

This comment has been minimized.

Show comment
Hide comment
@kddeisz

kddeisz Apr 12, 2018

Contributor

Came here to add this PR, found this one already open. Nice work!

Contributor

kddeisz commented Apr 12, 2018

Came here to add this PR, found this one already open. Nice work!

Show outdated Hide outdated activerecord/lib/active_record/relation.rb Outdated
@fatkodima

This comment has been minimized.

Show comment
Hide comment
@fatkodima

fatkodima Apr 13, 2018

Contributor

@rafaelfranca updated with your suggestion.

Contributor

fatkodima commented Apr 13, 2018

@rafaelfranca updated with your suggestion.

@rafaelfranca rafaelfranca merged commit 7bdfc63 into rails:master Apr 20, 2018

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment