Add touch_all method to ActiveRecord::Relation
#31513
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
|
Came here to add this PR, found this one already open. Nice work! |
| # Person.where(name: 'David').touch | ||
| # # => "UPDATE \"people\" SET \"updated_at\" = '2018-01-04 22:55:23.132670' WHERE \"people\".\"name\" = 'David'" | ||
| def touch_all(*names, time: nil) | ||
| attributes = Array(names) + klass.send(:timestamp_attributes_for_update_in_model) |
There was a problem hiding this comment.
I think we should just make those methods public, but part of the private API.
fatkodima
force-pushed
the
relation-touch_all
branch
from
365b8fb
to
73aa400
Compare
|
@rafaelfranca updated with your suggestion. |
|
the behaviour of this change is different from regular |
Follow up of rails#31513.
This PR is an update for #8343.
Differences/changes:
timeargument:updated_at/onas an always updated column