Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `touch_all` method to `ActiveRecord::Relation` #31513

Merged
merged 1 commit into from Apr 20, 2018

Conversation

@fatkodima
Copy link
Contributor

@fatkodima fatkodima commented Dec 19, 2017

This PR is an update for #8343.

Differences/changes:

  • accepts multiple column names
  • accepts optional time argument
  • addresses optimistic locking
  • not hardcoding :updated_at/on as an always updated column
@rails-bot
Copy link

@rails-bot rails-bot commented Dec 19, 2017

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@kddeisz
Copy link
Contributor

@kddeisz kddeisz commented Apr 12, 2018

Came here to add this PR, found this one already open. Nice work!

activerecord/lib/active_record/relation.rb Outdated
# Person.where(name: 'David').touch
# # => "UPDATE \"people\" SET \"updated_at\" = '2018-01-04 22:55:23.132670' WHERE \"people\".\"name\" = 'David'"
def touch_all(*names, time: nil)
attributes = Array(names) + klass.send(:timestamp_attributes_for_update_in_model)

This comment has been minimized.

@rafaelfranca

rafaelfranca Apr 12, 2018
Member

I think we should just make those methods public, but part of the private API.

@fatkodima fatkodima force-pushed the fatkodima:relation-touch_all branch to 73aa400 Apr 13, 2018
@fatkodima
Copy link
Contributor Author

@fatkodima fatkodima commented Apr 13, 2018

@rafaelfranca updated with your suggestion.

@rafaelfranca rafaelfranca merged commit 7bdfc63 into rails:master Apr 20, 2018
2 checks passed
2 checks passed
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@igorkasyanchuk
Copy link
Contributor

@igorkasyanchuk igorkasyanchuk commented Mar 13, 2019

the behaviour of this change is different from regular touch method, because with touch you can have a callback after_touch. And this change behaves identical to update_all.

kamipo added a commit to kamipo/rails that referenced this pull request Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.