Skip to content

Add touch_all method to ActiveRecord::Relation#31513

Merged
rafaelfranca merged 1 commit into
rails:masterfrom
fatkodima:relation-touch_all
Apr 20, 2018
Merged

Add touch_all method to ActiveRecord::Relation#31513
rafaelfranca merged 1 commit into
rails:masterfrom
fatkodima:relation-touch_all

Conversation

@fatkodima
Copy link
Copy Markdown
Member

@fatkodima fatkodima commented Dec 19, 2017

This PR is an update for #8343.

Differences/changes:

  • accepts multiple column names
  • accepts optional time argument
  • addresses optimistic locking
  • not hardcoding :updated_at/on as an always updated column

@rails-bot
Copy link
Copy Markdown

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@kddnewton
Copy link
Copy Markdown
Contributor

Came here to add this PR, found this one already open. Nice work!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should just make those methods public, but part of the private API.

@fatkodima fatkodima force-pushed the relation-touch_all branch from 365b8fb to 73aa400 Compare April 13, 2018 08:10
@fatkodima
Copy link
Copy Markdown
Member Author

@rafaelfranca updated with your suggestion.

@rafaelfranca rafaelfranca merged commit 7bdfc63 into rails:master Apr 20, 2018
@igorkasyanchuk
Copy link
Copy Markdown
Contributor

the behaviour of this change is different from regular touch method, because with touch you can have a callback after_touch. And this change behaves identical to update_all.

kamipo added a commit to kamipo/rails that referenced this pull request Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants