Handle FrozenError if it is available to 5-1-stable
#31525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request handles `FrozenError` introduced by Ruby 2.5. Refer https://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions/61131 Since `FrozenError` is a subclass of `RuntimeError` minitest used by master branch can handle it, though it would be better to handle `FrozenError` explicitly if possible. `FrozenError` does not exist in Ruby 2.4 or lower, `frozen_error_class` handles which exception is expected to be raised.
|
r? @kamipo (@rails-bot has picked a reviewer for you, use r? to override) |
|
|
rafaelfranca
pushed a commit
that referenced
this pull request
Dec 22, 2017
Handle `FrozenError` if it is available to 5-1-stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request backports #31520 to 5-1-stable where the actual failures reported like https://travis-ci.org/rails/rails/jobs/318867883
Summary
This pull request handles
FrozenErrorintroduced by Ruby 2.5.Refer https://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions/61131
Since
FrozenErroris a subclass ofRuntimeErrorminitest used by masterbranch can handle it, though it would be better to handle
FrozenErrorexplicitly if possible.
FrozenErrordoes not exist in Ruby 2.4 or lower,frozen_error_classhandles which exception is expected to be raised.