Remove ActiveModel::Attributes ??? #31848
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I suspect I have missed something here, but rails#31832 got me poking around in `ActiveModel::Attributes`, and I couldn't see where it was being used, except in a couple tests. If I am correct that this undocumented class is not being used anywhere in Rails, we should either remove it, or document it so people can use it. It does have some duplication with ActiveRecord::Attributes, so maybe we could clean that up as well. If I am NOT correct about any of this, I will be happy to learn why!
|
Thank you for the pull request. If you do some research about when this feature was added you can see that the idea is to make it public API. It is still not public, but it will be when we want it to be. |
|
Got it. I can see that now in 7e9ded5. I will get in the habit of checking the history before I make a PR like this. Sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suspect I have missed something here, but #31832
got me poking around in
ActiveModel::Attributes, andI couldn't see where it was being used, except in
a couple tests.
If I am correct that this undocumented (i.e. not public)
class is not being used anywhere in Rails, we should either
remove it, or document it so people can use it. It does have
some duplication with
ActiveRecord::Attributes, so maybewe could clean that up as well.
If I am NOT correct about any of this, I will be happy to learn what I got wrong. 馃樃
If this becomes mergeable, I would want to go through and make sure I am not negatively affecting test coverage. I removed those for now just to see if the build would pass. (Things were passing locally, but Travis runs a lot more test than I do!)