Use SuppressedSummaryReporter and Rails::TestUnitReporter only if needed

[Kevinrob]

Summary

Rails Minitest plugin should add SuppressedSummaryReporter only for replacing SummaryReporter and Rails::TestUnitReporter for ProgressReporter.
Currently, the plugin always add these two reporters without checking if it's necessary.

For example, kern/minitest-reporters can remove all reporters and set custom ones defined by the configuration.
Currently, rails will re-add reporters without checks.

[rails-bot]

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @kamipo (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

[Kevinrob]

PS: I don't find the information about which branch to target for this kind of pull request. I am sorry if it's wrong, I can change it 👍.

[y-yagi]

Thanks for your Pull Request.
Does this PR's purpose is to make it possible to invalidate reportesr provided by Rails?

[Kevinrob]

The purpose is to make possible to replace reporters.
You can check this related issue minitest-reporters/minitest-reporters#230.
minitest-reporters allow to use other reporters like SpecReporter, ProgressReporter, RubyMineReporter.

If I understand well, Rails doesn't check and add unconditionally these two reporters. This is what I would like to change.
I think that is the initial intention when we read the comment # Replace progress reporter for colors.

The other way may be to use an ENV variable for opt-out?

[y-yagi]

Thanks. We are considering adding the option to skip Rails' custom Minitest reporter.
#30555 (comment)

Probably I think that adding this option will satisfy your request.
So let's track that PR. Thank.

[matthewd]

I think that is the initial intention when we read the comment # Replace progress reporter for colors.

+1. We want to replace the original reporters; if they're not there, then we have nothing to do.

I suspect I already know the answer, but is it possible/practical to test this?

[Kevinrob]

One way for testing this is to move/extract the replacing logic to a method that take reporter as an argument and make unit test on this method. What do you think?
I will take a look at how minitest do tests. Maybe they test the plugin system.

[Kevinrob]

I added some tests 👍

[Kevinrob]

One job doesn't pass https://travis-ci.org/rails/rails/jobs/341311470

The job exceeded the maximum time limit for jobs, and has been terminated.

I don't think that I can do anything 😄

[rafaelfranca]

Can you add a changelog entry and squash your commits?

[Kevinrob]

@rafaelfranca I have added a changelog entry and squashed my commits 👍

[andreynering]

I'd be nice to have this fix backported to Rails 5.0.

[Kevinrob]

@andreynering Is there a process or a rule for backporting this kind of fix?
I can do the PR for this with pleasure 👍

[andreynering]

@Kevinrob Only the maintainers could tell if a backport for this would be accepted. (In theory, Rails 5.0 is not maintained anymore). If so, I'd also be open to work on this.

Do you know which version this patch was initially released for? v5.1? v5.2?

[Kevinrob]

Rails 5.2 I thing