Use rack-cache 1.1 #3202
Merged
Use rack-cache 1.1 #3202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Versions prior to 1.1 delete the If-Modified-Since and If-Not-Modified headers when config.action_controller.perform_caching is true. This has two problems: * unexpected inconsistent behaviour between development & production environments * breaks applications that use of these headers
|
Thanks! That was speedy :) |
|
A great pull request with tests is very likely to be merged fast. ;) Thank |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Versions of rack-cache prior to 1.1 delete the If-Modified-Since and If-Not-Modified headers when
config.action_controller.perform_cachingis true.This creates two problems:
I originally opened #3053 about this, but then discovered that Rails wasn't the culprit. The solution is upgrading to 1.1, which doesn't break anything as far as I could tell.
My test & changes are based off of master. I believe rack-cache 1.0.3 first appeared in some beta incarnation of 3.1, so it'd be good to get it into those branches if possible.