Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadowing outer variable - spec_name #32357

Closed
wants to merge 1 commit into from

Conversation

utilum
Copy link
Contributor

@utilum utilum commented Mar 27, 2018

Ruby >= 2.5 warns about this. 248 warnings in the test suite output...

@utilum utilum changed the title Pass inner spec_name in DatabaseConfig.walk_conifgs recursion Shadowing outer variable - spec_name Mar 27, 2018
@utilum utilum force-pushed the database_configurations branch 2 times, most recently from ec8880c to a14e888 Compare March 28, 2018 08:22
@pixeltrix
Copy link
Contributor

Ah, sorry @utilum I didn't see this PR when I noticed the warning this morning while investigating something else. 🙏

@pixeltrix pixeltrix closed this Mar 30, 2018
@utilum
Copy link
Contributor Author

utilum commented Mar 30, 2018

No worries :)
Perahps you'd care to look at #32366 ? Stumbled themupon together, but this other one is a tiny bit more touchy.

@utilum utilum deleted the database_configurations branch March 30, 2018 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants