Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.6 warnings: passing splat keyword arguments as a single Hash #32447

Merged
merged 1 commit into from
Apr 4, 2018
Merged

2.6 warnings: passing splat keyword arguments as a single Hash #32447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion actionview/lib/action_view/helpers/form_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1970,7 +1970,7 @@ def fields(scope = nil, model: nil, **options, &block)

convert_to_legacy_options(options)

fields_for(scope || model, model, **options, &block)
fields_for(scope || model, model, options, &block)
end

# Returns a label tag tailored for labelling an input field for a specified attribute (identified by +method+) on an object
Expand Down
5 changes: 3 additions & 2 deletions activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,8 @@ def create_table(table_name, comment: nil, **options)
yield td if block_given?

if options[:force]
drop_table(table_name, **options, if_exists: true)
drop_opts = { if_exists: true }.merge(**options)
drop_table(table_name, drop_opts)
end

result = execute schema_creation.accept td
Expand Down Expand Up @@ -908,7 +909,7 @@ def remove_reference(table_name, ref_name, foreign_key: false, polymorphic: fals
foreign_key_options = { to_table: reference_name }
end
foreign_key_options[:column] ||= "#{ref_name}_id"
remove_foreign_key(table_name, **foreign_key_options)
remove_foreign_key(table_name, foreign_key_options)
end

remove_column(table_name, "#{ref_name}_id")
Expand Down