Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci skip] Use consistent hash syntax in AR docs #33415

Merged
merged 1 commit into from Jul 22, 2018
Merged

[ci skip] Use consistent hash syntax in AR docs #33415

merged 1 commit into from Jul 22, 2018

Conversation

orhantoy
Copy link
Contributor

Summary

The examples with .where uses hash w/ symbol keys so it would be more consistent to also do this with .new. Also from my experience the hash w/ symbol keys is more widely with where/new/create etc. in ActiveRecord.

The examples with `.where` uses hash w/ symbol keys so it would be more consistent to also do this with `.new`.
Also from my experience the hash w/ symbol keys is more widely used with `where/new/create` etc. in ActiveRecord.
@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @pixeltrix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@georgeclaghorn georgeclaghorn merged commit 9732195 into rails:master Jul 22, 2018
@orhantoy orhantoy deleted the feature/docs-consistent-hash-syntax branch July 22, 2018 15:22
georgeclaghorn added a commit that referenced this pull request Jul 27, 2018
…syntax

[ci skip] Use consistent hash syntax in AR docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants