Add documentation for :collation column option
#33733
Conversation
The table definition supports a `:collation` option for string and text columns, but this is not documented anywhere that I could find. I'm not sure if the "If not specified" part is accurate. From [this PR](rails@1515c4d), it looks like it passes `nil` and lets the database handle the collation, but I'm happy to change it if I misread the code. [ci skip]
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @sgrif (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review. Please see the contribution instructions for more information. |
| @@ -521,7 +521,10 @@ def drop_table(table_name, options = {}) | |||
| # * <tt>:precision</tt> - | |||
| # Specifies the precision for the <tt>:decimal</tt> and <tt>:numeric</tt> columns. | |||
| # * <tt>:scale</tt> - | |||
| # Specifies the scale for the <tt>:decimal</tt> and <tt>:numeric</tt> columns. | |||
| # Specifies the scale for the <tt>:decimal</tt> and <tt>:numeric</tt> columns. | |||
There was a problem hiding this comment.
Can you remove the trailing whitespace that you added?
There was a problem hiding this comment.
Done. I was staring at that for like 10 minutes trying to figure out what the diff was.
Summary
The table definition supports a
:collationoption for string and text columns, but this is not documented anywhere that I could find.Other Information
I'm not sure if the "If not specified" part is accurate. From this PR, it looks like it passes
niland lets the database handle the collation, but I'm happy to change it if I misread the code.[ci skip]