New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make null_store the default cache store in test environment config #33773

Merged
merged 1 commit into from Sep 2, 2018

Conversation

Projects
None yet
4 participants
@mcnelson
Contributor

mcnelson commented Sep 1, 2018

Summary

It's surprising to me that by default, low-level caching is functional in the test environment. This simply adds config.cache_store = :null_store in config/environments/test.rb.

The existing defaults in test.rb as well as the Rails Guides kinda have you believe the null_store is the default.

Really was on the fence about opening this as it may not be a substantial enough change to warrant dev resources. But since Rails has such a great reputation of providing sane defaults, I felt like this would be worth it.

Other Information

I perused the tests and wasn't sure where best to add anything. railties/test/application/generators_test.rb?

Appropriate to update CHANGELOG?

@rails-bot

This comment has been minimized.

Show comment
Hide comment
@rails-bot

rails-bot Sep 1, 2018

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @eileencodes (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

rails-bot commented Sep 1, 2018

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @eileencodes (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@georgeclaghorn

This comment has been minimized.

Show comment
Hide comment
@georgeclaghorn

georgeclaghorn Sep 2, 2018

Member

I’ve stubbed my toe on this before. 👍

Nothing changes for existing apps unless they opt into the new default via rails app:update, so I don’t think a changelog entry is necessary. Thanks!

Member

georgeclaghorn commented Sep 2, 2018

I’ve stubbed my toe on this before. 👍

Nothing changes for existing apps unless they opt into the new default via rails app:update, so I don’t think a changelog entry is necessary. Thanks!

@georgeclaghorn georgeclaghorn merged commit 53eea40 into rails:master Sep 2, 2018

2 checks passed

codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@eileencodes

This comment has been minimized.

Show comment
Hide comment
@eileencodes

eileencodes Sep 2, 2018

Member

@mcnelson can you open a new PR with a changelog? It's important to mention this change in behavior.

Member

eileencodes commented Sep 2, 2018

@mcnelson can you open a new PR with a changelog? It's important to mention this change in behavior.

@mcnelson

This comment has been minimized.

Show comment
Hide comment
@mcnelson

mcnelson Sep 2, 2018

Contributor

Done: #33779

Contributor

mcnelson commented Sep 2, 2018

Done: #33779

bogdanvlviv added a commit to bogdanvlviv/rails that referenced this pull request Sep 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment