Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eager loading/preloading should be worked regardless of large number of records #33844

Merged
merged 1 commit into from
Sep 13, 2018
Merged

Eager loading/preloading should be worked regardless of large number of records #33844

merged 1 commit into from
Sep 13, 2018

Commits on Sep 11, 2018

  1. Eager loading/preloading should be worked regardless of large number … 

    …of records

Since 213796f, bind params are used for IN clause if enabled prepared
statements.

Unfortunately, most adapter modules have a limitation for # of bind
params (mysql2 65535, pg 65535, sqlite3 250000). So if eager loading
large number of records at once, that query couldn't be sent to the
database.

Since eager loading/preloading queries are auto-generated by Active
Record itself, so it should be worked regardless of large number of
records like as before.

Fixes rails#33702.
    @kamipo
    kamipo committed Sep 11, 2018
    Configuration menu
    Copy the full SHA
    a50eacb View commit details
    Browse the repository at this point in the history