Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise ActiveRecord::InvalidForeignKey in before_destroy for a blob if attachments exist #33899

Merged
merged 1 commit into from
Sep 17, 2018
Merged

Raise ActiveRecord::InvalidForeignKey in before_destroy for a blob if attachments exist #33899

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions activestorage/app/models/active_storage/blob.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ class ActiveStorage::Blob < ActiveRecord::Base

scope :unattached, -> { left_joins(:attachments).where(ActiveStorage::Attachment.table_name => { blob_id: nil }) }

before_destroy(prepend: true) do
raise ActiveRecord::InvalidForeignKey if attachments.exists?
end

class << self
# You can used the signed ID of a blob to refer to it on the client side without fear of tampering.
# This is particularly helpful for direct uploads where the client-side needs to refer to the blob
Expand Down