Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pluralization for 'canvas' #34036

Closed
wants to merge 3 commits into from
Closed

Add pluralization for 'canvas' #34036

wants to merge 3 commits into from

Conversation

ianrandmckenzie
Copy link

Summary

This is a proposed fix for the pluralization of the word "canvas." Related issue: #34035

This is only my second time contributing to open source (and my first time contributing to an active project), so please let me know if I'm doing anything wrong.

Cheers,

Ian

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @kaspth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

This repository is being automatically checked for code quality issues using Code Climate. You can see results for this analysis in the PR status below. Newly introduced issues should be fixed before a Pull Request is considered ready to review.

Please see the contribution instructions for more information.

@sharang-d
Copy link
Contributor

I don't think these are to be updated according to:

#--
# Defines the standard inflection rules. These are the starting point for
# new projects and are not considered complete. The current set of inflection
# rules is frozen. This means, we do not change them to become more complete.
# This is a safety measure to keep existing applications from breaking.
#++

@ianrandmckenzie
Copy link
Author

@sharang-d Ah, I completely missed that. Oops. I suppose this can be disregarded, then.

@kaspth
Copy link
Contributor

kaspth commented Oct 1, 2018

Yeah, the inflections are frozen. Thanks!

@kaspth kaspth closed this Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants