Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document deep_interpolation parameter for bulk lookups #34309

Merged
merged 1 commit into from Oct 25, 2018

Commits on Oct 25, 2018

  1. Document deep_interpolation parameter for bulk lookups

    Bulk lookups are sort of an edge case, I have not heard of them until a colleague of mine decided to dynamically iterate over a growing set of translations and receiving them in bulk as a hash with `I18n.t 'welcome'` as in the example above.
    
    When passing an interpolation to these bulk lookups, they will only be performed when also passing `deep_interpolation: true`.
    
    **Without passing `deep_interpolation` flag:**
    ```ruby
    I18n.t 'welcome', app_name: 'book store'
    # => {:title=>"Welcome!", :content=>"Welcome to the %{app_name}"}
    
    **With passing `deep_interpolation`:**
    I18n.t 'welcome', deep_interpolation: true, app_name: 'book store'
    # => {:title=>"Welcome!", :content=>"Welcome to the book store"}
    ```
    
    I found this digging in the I18n lookup backend, the flag is listed on [I18n's Rubydoc](https://www.rubydoc.info/github/svenfuchs/i18n/master/I18n) but not otherwise listed. Since bulk lookups are mentioned here, I suggest to add a note with this flag along with it.
    oliverguenther committed Oct 25, 2018
    Copy the full SHA
    4692ed7 View commit details
    Browse the repository at this point in the history