Commits on Oct 27, 2018

1. Ignore empty condition on #construct_relation_for_exists …

   At rails@fc0e335,
   
   ```rb
   relation = relation.where(conditions)
   ```
   
   was rewritten to:
   
   ```rb
   relation.where!(condition)
   ```
   
   This change accidentally changed the result of `Topic.exists?({})` from true to false.
   
   To fix this regression, first I moved the blank check logic (`opts.blank?`) from `#where` to `#where!`,
   because I thought `#where!` should be identical to `#where`, except that instead of returning a new relation,
   it adds the condition to the existing relation.
   
   But on second thought after some discussion on rails#34329,
   I started to think that just fixing `#construct_relation_for_exists` is more preferable
   than changing `#where` and `#where!`.

   

   r7kamura committed Oct 27, 2018
   Configuration menu

   • View commit details
   • Copy full SHA for 4694fcf
   • Browse repository at this point

   Copy the full SHA

   4694fcf View commit details

   Browse the repository at this point in the history