Fix inspect with non-primary key id attribute #34384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @schneems (@rails-bot has picked a reviewer for you, use r? to override) |
kamipo
reviewed
Nov 6, 2018
The `read_attribute` method always returns the primary key when asked to read the `id` attribute, even if the primary key isn't named `id`, and even if another attribute named `id` exists. For the `inspect`, `attribute_for_inspect` and `pretty_print` methods, this behaviour is undesirable, as they're used to examine the internal state of the record. By using `_read_attribute` instead, we'll get the real value of the `id` attribute.
eugeneius
force-pushed
the
inspect_with_non_primary_key_id_attribute
branch
from
6a4a643
to
65cd0fd
Compare
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
Jun 14, 2020
…t?}` It is considered as a regression for rails#34384.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34380.
The
read_attributemethod always returns the primary key when asked to read theidattribute, even if the primary key isn't namedid, and even if another attribute namedidexists.For the
inspect,attribute_for_inspectandpretty_printmethods, this behaviour is undesirable, as they're used to examine the internal state of the record. By using_read_attributeinstead, we'll get the real value of theidattribute.