Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ActiveStorage::Blob keys lowercase #34818

Merged
merged 12 commits into from Dec 30, 2018
Merged

Make ActiveStorage::Blob keys lowercase #34818

merged 12 commits into from Dec 30, 2018

Commits on Dec 28, 2018

  1. Make ActiveStorage::Blob keys lowercase

    @julik
    julik committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    eafd932 View commit details
    Browse the repository at this point in the history

  2. Alter test to compensate for key growth

    @julik
    julik committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    fc52c21 View commit details
    Browse the repository at this point in the history

  3. ...and off-by-1 errors

    @julik
    julik committed Dec 28, 2018
    Configuration menu
    Copy the full SHA
    971cbd6 View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2018

  1. Add changelog entry

    @julik
    julik committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    dd3aeaf View commit details
    Browse the repository at this point in the history

  2. Simplify test

    @julik
    julik committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    5aa22f1 View commit details
    Browse the repository at this point in the history

  3. Use SecureRandom better when generating the key 

    instead of downcasing the Base58 variant
    @julik
    julik committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    799fc52 View commit details
    Browse the repository at this point in the history

  4. Double quotes

    @julik
    julik committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    73c0340 View commit details
    Browse the repository at this point in the history

  5. Update the #key method comment

    @julik
    julik committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    ae68b6b View commit details
    Browse the repository at this point in the history

  6. Keys keys 

    keys
    @julik
    julik committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    cd611b9 View commit details
    Browse the repository at this point in the history

  7. Move base36 into AS core extension

    @julik
    julik committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    e1d5b41 View commit details
    Browse the repository at this point in the history

  8. Remove unused constant

    @julik
    julik committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    12e4ef0 View commit details
    Browse the repository at this point in the history

  9. All the edits 

    Braces are to avoid warnings when running tests as we start the arguments with a /
    @julik
    julik committed Dec 30, 2018
    Configuration menu
    Copy the full SHA
    c8ed90b View commit details
    Browse the repository at this point in the history