Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update terminal-to-html inline images url in ScreenshotHelper documentation #35173

Merged
merged 1 commit into from Feb 6, 2019

Conversation

betterzega
Copy link
Contributor

@betterzega betterzega commented Feb 6, 2019

Summary

Was reading through the documentation for the ScreenshotHelper class. Noticed that the terminal artifact format reference URL (https://buildkite.github.io/terminal/inline-images/) is out of date and leads to a 404 page. Updated it to the new URL https://buildkite.github.io/terminal-to-html/inline-images/

@rails-bot rails-bot bot added the actionpack label Feb 6, 2019
@betterzega betterzega changed the title Update terminal-to-html inline images url in ScreenshotHelper Update terminal-to-html inline images url in ScreenshotHelper documentation Feb 6, 2019
@y-yagi
Copy link
Member

y-yagi commented Feb 6, 2019

I confirmed this changed with this commit

@y-yagi y-yagi merged commit f16a397 into rails:master Feb 6, 2019
@y-yagi
Copy link
Member

y-yagi commented Feb 6, 2019

@betterzega Thanks! In the future, please add [ci skip] to commit message for skip the Travis build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants