Fix the regex that extract mismatched foreign key information #35299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CI failure for `test_errors_for_bigint_fks_on_integer_pk_table` is due to the poor regex that extract all ``` `(\w+)` ``` like parts from the message (`:foreign_key` should be `"old_car_id"`, but `"engines"`): https://travis-ci.org/rails/rails/jobs/494123455#L1703 I've improved the regex more strictly and have more exercised mismatched foreign key tests. Fixes rails#35294
kamipo
added a commit
that referenced
this pull request
Feb 16, 2019
Fix the regex that extract mismatched foreign key information
kamipo
added a commit
that referenced
this pull request
Feb 16, 2019
Fix the regex that extract mismatched foreign key information
eileencodes
pushed a commit
to eileencodes/rails
that referenced
this pull request
Mar 9, 2019
Fix the regex that extract mismatched foreign key information Backported from 5-2-stable to fix the maria db failure seen https://travis-ci.org/rails/rails/jobs/503455456
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI failure for
test_errors_for_bigint_fks_on_integer_pk_tableisdue to the poor regex that extract all
`(\w+)`like parts fromthe message (
:foreign_keyshould be"old_car_id", but"engines"):https://travis-ci.org/rails/rails/jobs/494123455#L1703
I've improved the regex more strictly and have more exercised mismatched
foreign key tests.
Fixes #35294