Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3 1 stable url subdomain with numeric host #3561

Merged
merged 2 commits into from
Nov 8, 2011
Merged

3 1 stable url subdomain with numeric host #3561

merged 2 commits into from
Nov 8, 2011

Commits on Nov 8, 2011

  1. Fix trouble using :subdomain in development environment when using nu… 

    …meric addresses.

Otherwise the following occurs:

TypeError: can't convert nil into String
    /Users/bfolkens/dev/bfolkens-rails-core/actionpack/lib/action_dispatch/http/url.rb:75:in host_or_subdomain_and_domain'
    /Users/bfolkens/dev/bfolkens-rails-core/actionpack/lib/action_dispatch/http/url.rb:37:in url_for'
    /Users/bfolkens/dev/bfolkens-rails-core/actionpack/lib/action_dispatch/routing/url_for.rb:147:in test_subdomain_may_be_accepted_with_numeric_host'
    /Users/bfolkens/dev/bfolkens-rails-core/activesupport/lib/active_support/testing/setup_and_teardown.rb:67:in run'
    /Users/bfolkens/dev/bfolkens-rails-core/activesupport/lib/active_support/callbacks.rb:426:in send'
    /Users/bfolkens/dev/bfolkens-rails-core/activesupport/lib/active_support/callbacks.rb:81:in run'
    @bfolkens
    bfolkens committed Nov 8, 2011
    Configuration menu
    Copy the full SHA
    92955d0 View commit details
    Browse the repository at this point in the history

  2. Fixed ' and ' should be ' && '

    @bfolkens
    bfolkens committed Nov 8, 2011
    Configuration menu
    Copy the full SHA
    0fdcd54 View commit details
    Browse the repository at this point in the history