Update find or create by #35633
Closed
Update find or create by #35633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcameron89
force-pushed
the
update_find_or_create_by
branch
from
23ef099
to
f99453c
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
@alexcameron89 was there ever any more discussion on this one? Just read over #35543 and this does still feel like a good idea. |
ChanChar
added a commit
to ChanChar/rails
that referenced
this pull request
Apr 13, 2022
Updates `#create_or_find_by` to accept an optional `options` key to house a new `find_first` flag. This flag specifies that the method runs a `#find_by` before attempting the create. This can help mitigate a few potential issues: * (Impact) Description * (Medium) Reduces write load. In most cases, this method is useful to create a record once with all subsequent calls using `#find_by` as a fallback. The proactive `#find_by` can skip the create/rescue loop and mostly rely on the initial fetch. * (Low) Reduces the risk of unneccesary PK increments when an existing record exists (ie. some versions of MySQL increment the PK on INSERT, regardless of whether or not it succeeds). References rails#35543 [Previous implementation](rails#35633)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I believe these are the changes needed to make
find_or_create_byfail in similar ways tocreate_or_find_by, but I'm struggling to find an appropriate way to validate that through tests.