Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove roflscaling #35664

Merged
merged 2 commits into from Mar 19, 2019
Merged

Remove roflscaling #35664

merged 2 commits into from Mar 19, 2019

Conversation

@jeremyevans
Copy link
Contributor

@jeremyevans jeremyevans commented Mar 18, 2019

roflscaling (using frozen string constants instead of literal
strings) was added in 2012, before frozen string literals were
added in Ruby 2.3. Now that Rails no longer supports Ruby <2.3,
and all of these files use frozen string literals, there is
no reason to keep the roflscaling.

This does not delete or deprecate the related constants. Such
a change can be made in a later commit.

@tenderlove may want to review this as he added the roflscaling
in e232226.

roflscaling (using frozen string constants instead of literal
strings) was added in 2012, before frozen string literals were
added in Ruby 2.3.  Now that Rails no longer supports Ruby <2.3,
and all of these files use frozen string literals, there is
no reason to keep the roflscaling.

This does not delete or deprecate the related constants. Such
a change can be made in a later commit.
@tenderlove
Copy link
Member

@tenderlove tenderlove commented Mar 18, 2019

Awesome! Glad we can get rid of this junk! ❤️🧡💛💚💙💜🖤

@jeremy
jeremy approved these changes Mar 19, 2019
Copy link
Member

@jeremy jeremy left a comment

Yes! Can we remove the constants as well? They're :nodoc:-private.

@jeremyevans
Copy link
Contributor Author

@jeremyevans jeremyevans commented Mar 19, 2019

Sure, here's another commit to remove the constants.

@rafaelfranca rafaelfranca merged commit fbc2e67 into rails:master Mar 19, 2019
1 of 3 checks passed
1 of 3 checks passed
buildkite/rails Build #59694 failed (16 minutes, 34 seconds)
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
codeclimate All good!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants