Add rake db:prepare entry to the CHANGELOG.md #35841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simi
approved these changes
Apr 3, 2019
kamipo
reviewed
Apr 3, 2019
activerecord/CHANGELOG.md
Outdated
| @@ -1,3 +1,7 @@ | |||
| * Add `rake db:prepare` runs setup if database does not exist, or runs migrations if it does | |||
There was a problem hiding this comment.
Don't need double spaces.
Suggested change
| * Add `rake db:prepare` runs setup if database does not exist, or runs migrations if it does | |
| * Add `rake db:prepare` runs setup if database does not exist, or runs migrations if it does. |
simi
reviewed
Apr 3, 2019
activerecord/CHANGELOG.md
Outdated
| @@ -1,3 +1,7 @@ | |||
| * Add `rake db:prepare` runs setup if database does not exist, or runs migrations if it does | |||
There was a problem hiding this comment.
nitpick: I think it is common to add entry as a sentence, to make this sentence I think it should end with . symbol.
robertomiranda
force-pushed
the
r/rake-db-prepare-changelog
branch
from
6ae449b
to
a877396
Compare
robertomiranda
force-pushed
the
r/rake-db-prepare-changelog
branch
from
a877396
to
eca847f
Compare
|
Thanks. In the future, you can add |
|
oh thanks, didn't know that @kamipo |
sharang-d
reviewed
Apr 3, 2019
| @@ -1,3 +1,7 @@ | |||
| * Add `rake db:prepare` runs setup if database does not exist, or runs migrations if it does. | |||
There was a problem hiding this comment.
We can replace 'runs' with 'which runs'.
|
Reformatted this in 9864f5e to fit the writing style of other entries — also switches to |
|
thanks @kaspth |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a missing entry into the
CHANGELOG.mdfile.ref #35768 (comment)