Fix arity warning for template handlers #35858
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The warning displayed a generic
Class
string instead of the class name (e.g.Coffee::Rails::TemplateHandler
).This makes it difficult to know which template handler is responsible for the warning and thus which one needs to be updated.
extensions
could also be used and may lead to a better error message.Other Information
A test would be great, not sure how I would do that though (either using an old gem version or mocking a template handler). At least it works in my manual testing.
I also fixed the instance method call to a class method call as this is how
Coffee::Rails::TemplateHandler
handles it: