Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guide updated in line with changes in rails commands [skip ci] #35994

Merged

Conversation

soartec-lab
Copy link
Contributor

Summary

The guide has also been updated as the rails commands change.

  • Gemfiles generated by rails new do not include gems coffee-rails and uglifier
  • The generate commands neither scaffold nor controller generate JavaScript files.
  • The newly created Rails application does not include the app / assets / javascripts / application.js file by default.

@rails-bot rails-bot bot added the docs label Apr 16, 2019
@kaspth kaspth merged commit c025710 into rails:master Apr 16, 2019
@kaspth
Copy link
Contributor

kaspth commented Apr 16, 2019

Thanks!


```ruby
gem 'sass-rails'
gem 'uglifier'
gem 'coffee-rails'
```

Using the `--skip-sprockets` option will prevent Rails from adding
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋

I was reading this guide and noticed a bit of confusing wording on the two lines following this one (unfortunately GitHub won't let me comment directly on those lines). After looking through the history I found that the wording became confusing when this PR removed the mentions of uglifier and coffee-rails, leaving only sass-rails.

So, I've gone ahead and opened #38782 as a follow-up to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants