Include Caching module for ActionController::API #36038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently ActionController::API doesn't include Caching module, so it can't perform caching. And even if users include it later manually, it won't inherit application's default cache store for action_controllers. So the only way to solve this issue is to include Caching module in ActionController::API, too. This closes rails#35602
guilleiguaran
approved these changes
Apr 22, 2019
|
It is missing the documentation updated. And do we want caching by default in API? |
|
I don't think we want caching by default in API even more because it is about view caching. Not all API controller will use view caching. And the fact that the caching config don't reflect to later included inside the controller. I'm going to revert this. |
|
@rafaelfranca good point 👍will open another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #35602, currently
ActionController::APIdoesn't includeCachingmodule, so it can't perform caching. And even if users include it later manually, it won't inherit application's default cache store forconfig.action_controller.So the only way to solve this issue is to include Caching module in
ActionController::APItoo.This closes #35602