Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes grammar in comments on tag_name and tag_id #36098

Merged
merged 1 commit into from
Apr 26, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions actionview/lib/action_view/helpers/tags/base.rb
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ def add_default_name_and_id(options)
end

def tag_name(multiple = false, index = nil)
# a little duplication to construct less strings
# a little duplication to construct fewer strings
case
when @object_name.empty?
"#{sanitized_method_name}#{multiple ? "[]" : ""}"
Expand All @@ -118,7 +118,7 @@ def tag_name(multiple = false, index = nil)
end

def tag_id(index = nil)
# a little duplication to construct less strings
# a little duplication to construct fewer strings
case
when @object_name.empty?
sanitized_method_name.dup
Expand Down