Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: create a newline before group, github and source #36723

Merged

Conversation

masakazutakewaka
Copy link
Contributor

@masakazutakewaka masakazutakewaka commented Jul 22, 2019

Summary

Add newlines before group, source(with block) and github(outside block)

fix #35285

master

gem 'fake'
source 'http://gems.github.com' do
  gem 'rspec-rails'
end
github 'user/repo' do
  gem 'foo'
end
group :development do
  gem 'fuga'
end
group :magic do
  github 'user/repo' do
    gem 'foo'
  end
  github 'user/repo2' do
    gem 'foo2'
  end
end

this branch

gem 'fake'

source 'http://gems.github.com' do
  gem 'rspec-rails'
end

github 'user/repo' do
    gem 'foo'
end

group :development do
  gem 'fuga'
end

group :magic do
  github 'user/repo' do
    gem 'foo'
  end
  github 'user/repo2' do
    gem 'foo2'
  end
end

reference

#35285 (comment)

@rails-bot rails-bot bot added the railties label Jul 22, 2019
@masakazutakewaka masakazutakewaka changed the title FIX: create a newline between blocks when gem_group, github and add_source was called FIX: create a newline before group, github and source Jul 22, 2019
@kamipo kamipo merged commit 9ad8068 into rails:master Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants