Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize doc style for 'update_counters()' [ci skip] #36896

Merged
merged 1 commit into from
Aug 8, 2019

Conversation

sharang-d
Copy link
Contributor

Before:
Ruby on Rails API 2019-08-09 02-03-48

After:
Ruby on Rails API 2019-08-09 02-06-35

General style:
Ruby on Rails API 2019-08-09 02-05-18

@rafaelfranca rafaelfranca merged commit 9ddd936 into rails:master Aug 8, 2019
@sharang-d sharang-d deleted the doc-fix branch August 9, 2019 08:20
@sharang-d
Copy link
Contributor Author

There are a lot of other places where different formatting is used. I can't make out if it is on purpose or a mistake:
Monosnap 2019-08-09 13-51-16

@rafaelfranca
Copy link
Member

We need to be consistent. Check which one is more used and change all others to follow it.

@sharang-d
Copy link
Contributor Author

Yes, I figured the consistency part but I am a little confused because there are some docs wherein 3= and/or 2= and/or 4= are used(in the same method doc i.e.). I don't know if they are really used to make different heading levels or they are just mistakes. Did you mean to say we should always use 4=?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants