Clear ActiveRecord object memoized by take #36985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmolarora
force-pushed
the
fix-take-memoization
branch
from
c5322ec
to
2a65310
Compare
matthewd
reviewed
Aug 20, 2019
| Post.create!(title: idx.to_s, body: idx.to_s) | ||
| end | ||
|
|
||
| posts = Post.all |
There was a problem hiding this comment.
Let's put an order(:title) on here, otherwise the test will fail sporadically when the database happens to return "3" in the first take
There was a problem hiding this comment.
There is only one Post in the DB with title '3'.
Will this still be a problem?
There was a problem hiding this comment.
Oh, sorry, I was concerned that "3" might get [legitimately] chosen as first_post, and then the assert_not_equal would fail -- but it's comparing object_id, so it will actually be fine even if they both contain the same row. 👍
rafaelfranca
pushed a commit
that referenced
this pull request
Aug 20, 2019
Clear ActiveRecord object memoized by take
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ActiveRecordobject is memoized whentakeis called on a relation which is returned whenwhere/find_byis called on the same relation.This memoized state of the object needs to be cleared.
Fixes #36977