Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept columns passed with options in remove_index #37168

Merged
merged 1 commit into from
Sep 10, 2019
Merged

Accept columns passed with options in remove_index #37168

merged 1 commit into from
Sep 10, 2019

Commits on Sep 10, 2019

  1. Accept columns passed with options in remove_index 

    Before this patch, column names could only be passed as a positional
argument when no other options were supplied:

    remove_index :reports, :report_id

Passing column names positionally along with other options would fail:

    remove_index :reports, :report_id, unique: true
    # => ArgumentError: wrong number of arguments (given 3, expected 1..2)
    @eugeneius
    eugeneius committed Sep 10, 2019
    Configuration menu
    Copy the full SHA
    0cc13d3 View commit details
    Browse the repository at this point in the history