Fix error message for AdapterNotFound in spec #37180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When this case was his previously, an error would be thrown like: `<NoMethodError: "undefined method config for...">` because we were erroneously calling `config` on a `Hash`. This commit adds a test for this case, and fixes the hash access.
eileencodes
added a commit
that referenced
this pull request
Sep 12, 2019
Fix error message for AdapterNotFound in spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this case was his previously, an error would be thrown like:
<NoMethodError: "undefined method config for...">because we wereerroneously calling
configon aHash.This PR adds a test for this case, and fixes the hash access.
cc / @eileencodes