Avoid setting up file watcher on cache_classes #37216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if cache_classes was true we would build a file_watcher and add it to reloaders though it would never be used. This wasted some memory for FileUpdateChecker to maintain an array of all watched files, and added slightly to boot time. Instead we should avoid building a file watcher it when cache_classes is true.
kaspth
approved these changes
Sep 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if
cache_classeswas true we would build afile_watcherand add it toreloadersthough it would never be used. This wasted some memory forFileUpdateCheckerto maintain an array of all watched files, and added slightly to boot time.Instead we should avoid building a file watcher it when
cache_classesistrue.