Deprecate to_h and to_legacy_hash
#37231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These should have been deprecated when I added them but for some reason I didn't. As we move away from passing hashes around we no longer need these methods, and since we no longer use configuration hashes as database configuration we can deprecate this in favor of using the database configuration objects and access the connection hashes from there. Co-authored-by: John Crepezzi <john.crepezzi@gmail.com>
|
Are |
rafaelfranca
approved these changes
Sep 18, 2019
casperisfine
approved these changes
Sep 18, 2019
|
👋 @sikachu 👍 on a |
|
@seejohnrun can you send a changelog entry? I can't push code right now 😅 |
seejohnrun
added a commit
to seejohnrun/rails
that referenced
this pull request
Sep 18, 2019
We deprecated `to_h` in rails#37231, and this commit adds the appropriate `CHANGELOG` entry!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These should have been deprecated when I added them but for some reason
I didn't.
As we move away from passing hashes around we no longer need these
methods, and since we no longer use configuration hashes as database
configuration we can deprecate this in favor of using the database
configuration objects and access the connection hashes from there.
cc/ @seejohnrun @casperisfine @matthewd @rafaelfranca