Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Railties test suite for Sprockets 4.0 #37419

Merged
merged 8 commits into from
Oct 10, 2019
Merged

Fix Railties test suite for Sprockets 4.0 #37419

merged 8 commits into from
Oct 10, 2019

Commits on Oct 10, 2019

  1. Bundle update

    @jhawthorn
    jhawthorn committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    fe85234 View commit details
    Browse the repository at this point in the history

  2. Fix Sprockets::DoubleLinkError in test

    @jhawthorn
    jhawthorn committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    4cb93a3 View commit details
    Browse the repository at this point in the history

  3. Add a few more assertions

    @jhawthorn
    jhawthorn committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    added06 View commit details
    Browse the repository at this point in the history

  4. Maybe we understand index.js better now?

    @jhawthorn
    jhawthorn committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    5a4d4c7 View commit details
    Browse the repository at this point in the history

  5. Use a stylesheet instead of a javascript in test 

    We no longer link all js by default, so we should do this test with a
css instead (we don't care about that specifics of the dir just that its
in the manifest and in this dir).
    @jhawthorn
    jhawthorn committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    e636955 View commit details
    Browse the repository at this point in the history

  6. Remove a javascript from test

    @jhawthorn
    jhawthorn committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    8d037fd View commit details
    Browse the repository at this point in the history

  7. Link .js from manifest.js in assets_test 

    We no longer link JS by default, we need to modify manifest.js for that
now.
    @jhawthorn
    jhawthorn committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    4419176 View commit details
    Browse the repository at this point in the history

  8. Sprockets uses debug. not self. now

    @jhawthorn
    jhawthorn committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    72b1ae6 View commit details
    Browse the repository at this point in the history