Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve read_multi_entries performance for numerous keys #37440

Merged
merged 1 commit into from Oct 11, 2019
Merged

Improve read_multi_entries performance for numerous keys #37440

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
25 changes: 11 additions & 14 deletions activesupport/lib/active_support/cache.rb
View file
Open in desktop
Expand Up @@ -583,23 +583,20 @@ def write_entry(key, entry, **options)
# Reads multiple entries from the cache implementation. Subclasses MAY
# implement this method.
def read_multi_entries(names, **options)
results = {}
names.each do |name|
key = normalize_key(name, options)
names.each_with_object({}) do |name, results|
key = normalize_key(name, options)
entry = read_entry(key, **options)

next unless entry

version = normalize_version(name, options)
entry = read_entry(key, **options)

if entry
if entry.expired?
delete_entry(key, **options)
elsif entry.mismatched?(version)
# Skip mismatched versions
else
results[name] = entry.value
end

if entry.expired?
delete_entry(key, **options)
elsif !entry.mismatched?(version)
results[name] = entry.value
end
end
results
end

# Writes multiple entries to the cache implementation. Subclasses MAY
Expand Down