Allow escaping of literal colons in ActionRecord::Sanitization#replace_named_bind_variables #37797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Despite the inconvenience of double-backslashing, the backslash was chosen because it's a very common char to use in escaping across multiple programming languages. A developer, without looking at documentation, may intuitively try to use it to achieve the desired results in this scenario. Fixes rails#37779
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
Can we update this one? |
|
Hi guys, |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
Would be great to update this one! |
|
This is still a problem... |
|
I'm unable to reopen because the PR is pointing at the |
Merged
4 tasks
|
Hiya @skipkayhil, I've recreated the PR against |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #37779.
This PR simply allows the ability to escape literal colons in SQL when using named bind params. See the above issue for a detailed description of the problem.
Other Information
If this proposal is accepted, I would love to also backport to 5.x as well.