Add ActionText installer rake task

[abhaynikam]

After changes in #35085

While I was debugging this #37818, I faced with the issue where rails action_text:install as mentioned in the documentation was not working. After debugging for long it landed me to this PR: #35085

PR moved the ActionText installer from task to generator. The documentation and warning message where user was suggested to run generator was not updated. This PR update the mention on ActionText installer.

I am not confident about changes in tasks/release file. Please do let me know if we need to revert it.

[abhaynikam]

Ping. Added as per https://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#get-some-feedback

[kaspth]

This ain't right. We should have an action_text:install command that forwards to generate action_text:install. cc @vinistock

[vinistock]

@kaspth maybe I misunderstood, but I thought the intention was to get rid of the rake task.

We can add it back in if that's the desire. Just re-create actiontext/lib/tasks/actiontext.rake and make it invoke the generator. @abhaynikam would you like to tackle it? If not I can put together a PR.

[abhaynikam]

Thanks for the feedback @kaspth. @vinistock I would love to.

[abhaynikam]

@vinistock @kaspth Could you please review the changes? I tested it on one of the development app. The rake task is shown in the list of tasks(rake -T) and also run properly.

[kaspth]

Hm, this doesn't seem right to me. Though I can see we're doing the same thing in the Action Mailbox install Rakefile.

Can we require the correct generator and call start on it like we do in the credentials command? (Assuming that'll still trigger the test framework hook.)

@y-yagi would you happen to have any opinions here?

[abhaynikam]

I tried requiring the generator and running it. The test framework hook didn't get invoked.

[vinistock]

I agree that we shouldn't run it from the bin file. Would this method be of help in this case?

[kaspth]

That method is only to be run within a generator, not from a Rake task.

[vinistock]

I see. How about this one? Could that be invoked from a rake task?

[kaspth]

Then I'd prefer to just do something like:

task "action_text:install" do
  require "rails/command" # Can't remember the require path or if Rake tasks already have access to Rails::Command.
  Rails::Command.invoke "generate action_text:install"
end

[abhaynikam]

Did the necessary changes. Removing desc hide a generator from the list.

[kaspth]

We probably also want to ensure we don't show the action_text:install generate task when printing every generator.

There's also an opportunity to convert Action Mailbox to use an install generator as well, after this.

[kaspth]

@vinistock from the users perspective, the fact that we accomplish the install logic via a generator is incidental (e.g. we just switched to it) and the public installer interface is bin/rails action_text:install.

[vinistock]

@kaspth that makes sense. How does one hide a generator from the list?

[kaspth]

Can't remember, I'm assuming @abhaynikam can look at other generators or a method called something like printing_generators where the generators are printed for ideas.

[kaspth]

@abhaynikam looking better! Surprised we have access to Rails::Command out of the box. Makes sense if people are running bin/rails action_text:install but is that also true for rake action_text:install?

About desc, we want bin/rails action_text:install to show up when printing bin/rails --help removing desc breaks that. It's the action_text:install that we want to hide when doing bin/rails generate --help, not the command (otherwise why bother adding the command?).

[abhaynikam]

@kaspth

but is that also true for rake action_text:install?

Yep. Works with rake action_text:install as well.

About desc, we want bin/rails action_text:install to show up when printing bin/rails --help removing desc breaks that. It's the action_text:install that we want to hide when doing bin/rails generate --help, not the command

Sorry, I misunderstood. I have fixed it in the latest commit. Thanks

[vinistock]

It's looking good to me!

[kaspth]

@abhaynikam perfect, thanks so much! @vinistock thanks for the extra eyes too. 😄🙏 to you both