Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for if_exists/if_not_exists on remove_column/add_column #38352

Merged
merged 1 commit into from
Jan 30, 2020

Commits on Jan 30, 2020

  1. Add support for if_exists/if_not_exists on remove_column/add_column

    This PR adds support for `if_exists` on `remove_column` and
    `if_not_exists` on `add_column` to support silently ignoring migrations
    if the remove tries to remove a non-existent column or an add tries to
    add an already existing column.
    
    We (GitHub) have custom monkey-patched support for these features and
    would like to upstream this behavior.
    
    This matches the same behavior that is supported for `create_table` and
    `drop_table`. The behavior for sqlite is different from mysql/postgres
    and sqlite for remove column and that is reflected in the tests.
    eileencodes committed Jan 30, 2020
    Configuration menu
    Copy the full SHA
    95ed7e7 View commit details
    Browse the repository at this point in the history