Improve zeitwerk:check warning message [CI skip] #38374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The messages that are printed to the console when users run rails zeitwerk:check can be a little confusing if they've generated a mailer, as the test files aren't included by default, and a warning appears about this. To address this issue the warning message has been improved so that it is clearer that this behaviour is normal and it explicitly states that the user must configure eager loading to silence these warnings. Fixes rails#38156
|
ACK! |
|
I'll do a small edit after merging, but this message is better. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The messages that are printed to the console when users run rails zeitwerk:check
can be a little confusing if they've generated a mailer, as the test files aren't
included by default, and a warning appears about this.
To address this issue the warning message has been improved so that it is clearer
that this behaviour is normal and it explicitly states that the user must configure
eager loading to silence these warnings. Fixes #38156