Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove :rdoc Rake task in generated plugin #38574

Merged
merged 1 commit into from Apr 5, 2020
Merged

Remove :rdoc Rake task in generated plugin #38574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions railties/CHANGELOG.md
View file
Open in desktop
@@ -1,3 +1,9 @@
* No longer include `rake rdoc` task when generating plugins.

To generate docs, use the `rdoc lib` command instead.

*Jonathan Hefner*

* Allow relative paths with trailing slashes to be passed to `rails test`.

*Eugene Kenny*
Expand Down
9 changes: 0 additions & 9 deletions railties/lib/rails/generators/rails/plugin/templates/Rakefile.tt
View file
Open in desktop
@@ -1,13 +1,4 @@
require "bundler/setup"
require "rdoc/task"

RDoc::Task.new(:rdoc) do |rdoc|
rdoc.rdoc_dir = 'rdoc'
rdoc.title = '<%= camelized_modules %>'
rdoc.options << '--line-numbers'
rdoc.rdoc_files.include('README.md')
rdoc.rdoc_files.include('lib/**/*.rb')
end
<% if engine? && !options[:skip_active_record] && with_dummy_app? -%>

APP_RAKEFILE = File.expand_path("<%= dummy_path -%>/Rakefile", __dir__)
Expand Down
1 change: 1 addition & 0 deletions railties/lib/rails/generators/rails/plugin/templates/gitignore.tt
View file
Open in desktop
@@ -1,4 +1,5 @@
/.bundle/
/doc/
/log/*.log
/pkg/
/tmp/
Expand Down