Disallow calling connected_to on subclasses of ActiveRecord::Base
#38580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eileencodes
force-pushed
the
disallow-calling-connected_to-on-subclasses-of-ar-base
branch
from
13ef4ff
to
90d6b80
Compare
rafaelfranca
approved these changes
Feb 26, 2020
Behavior has not changed here but the previous API could be misleading to people who thought it would switch connections for only that class. `connected_to` switches the context from which we are getting connections, not the connections themselves. Co-authored-by: John Crepezzi <john.crepezzi@gmail.com>
seejohnrun
force-pushed
the
disallow-calling-connected_to-on-subclasses-of-ar-base
branch
from
90d6b80
to
b7b26fa
Compare
|
@rafaelfranca Fixed now, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Behavior has not changed here but the previous API could be
misleading to people who thought it would switch connections for only
that class.
connected_toswitches the context from which we aregetting connections, not the connections themselves.
cc / @eileencodes