Disable colorize logging of SQL and reduce unnecessary invocation of sql_color matching #38690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| name = colorize_payload_name(name, payload[:name]) | ||
| sql = color(sql, sql_color(sql), true) | ||
| if colorize_logging | ||
| name = colorize_payload_name(name, payload[:name]) |
There was a problem hiding this comment.
Do this need to be inside the if. color will take care of it.
There was a problem hiding this comment.
@rafaelfranca I did necessary changes for it. Please have a look. Thanks
…sql_color matching When the `colorize_logging` is disabled, logs do not colorize the SQL queries. But the `sql_color` method is always invoked which due to regex matching results in slow queries. This PR fixes rails#38685 and removes unnecessary invokation of `sql_color` method when `colorize_logging` is disabled
abhaynikam
force-pushed
the
38685-add-option-to-disable-sql-color
branch
from
d79aa05
to
85b5cd3
Compare
rafaelfranca
added a commit
that referenced
this pull request
Mar 12, 2020
…-sql-color Disable colorize logging of SQL and reduce unnecessary invocation of sql_color matching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
colorize_loggingis disabled, logs do not colorize the SQL queries. But thesql_colormethod is always invoked which due to regex matching results in slow queries.This PR fixes #38685 and removes unnecessary invocation of
sql_colormethod whencolorize_loggingis disabled